-
Notifications
You must be signed in to change notification settings - Fork 105
Epic 472 port nginx one labs #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview will be available once build job completes!
|
content/nginx-one/workshops/lab2/run-workshop-components-with-docker.md
Outdated
Show resolved
Hide resolved
content/nginx-one/workshops/lab3/explore-nginx-one-console-and-features.md
Outdated
Show resolved
Hide resolved
content/nginx-one/workshops/lab3/explore-nginx-one-console-and-features.md
Outdated
Show resolved
Hide resolved
static/workshops/nginx-one/lab2/nginx-oss/etc/nginx/conf.d/stub_status.conf
Outdated
Show resolved
Hide resolved
static/workshops/nginx-one/lab2/nginx-oss/etc/nginx/conf.d/tls-cars.example.com.conf
Outdated
Show resolved
Hide resolved
* Ported lab 5
…entation into epic-472-port-nginx-one-labs
edits from tech review Co-authored-by: yar <[email protected]>
…entation into epic-472-port-nginx-one-labs
content/includes/use-cases/monitoring/enable-nginx-plus-api-with-config-sync-group.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review in progress
content/nginx-one/workshops/lab1/getting-started-with-nginx-one.md
Outdated
Show resolved
Hide resolved
content/nginx-one/workshops/lab1/getting-started-with-nginx-one.md
Outdated
Show resolved
Hide resolved
content/nginx-one/workshops/lab1/getting-started-with-nginx-one.md
Outdated
Show resolved
Hide resolved
content/nginx-one/workshops/lab1/getting-started-with-nginx-one.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR may be step 1. I see no showstoppers in this PR. I've made a number of suggestions. If you agree with them and want to move to the next task, I'm good if you want to "save them for later".
content/nginx-one/workshops/lab1/getting-started-with-nginx-one.md
Outdated
Show resolved
Hide resolved
content/nginx-one/workshops/lab1/getting-started-with-nginx-one.md
Outdated
Show resolved
Hide resolved
content/nginx-one/workshops/lab3/explore-nginx-one-console-and-features.md
Show resolved
Hide resolved
content/nginx-one/workshops/lab3/explore-nginx-one-console-and-features.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a number of suggestions. I've spot checked some of the steps, and they work fine
My suggestions are not mandatory, though this comment bothers me. Maybe the best approach is to change the UI
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Give a brief overview of the problem or feature being addressed.
Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.
Testing: Describe any testing that you did.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
If this PR addresses an issue on GitHub, ensure that you link to it here:
Closes #ISSUE
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩